Skip to content

Conversation

@Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Mar 24, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Introduced in #35120. This was breaking the Poll App, this is why it was noticed.

Steps to test or reproduce

Further comments

CONN-569

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 24, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@Gustrb Gustrb added this to the 7.6.0 milestone Mar 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35603/

Built to branch gh-pages at 2025-03-25 18:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (47ae699) to head (dc1e541).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35603   +/-   ##
========================================
  Coverage    59.73%   59.73%           
========================================
  Files         2830     2830           
  Lines        68258    68258           
  Branches     15130    15130           
========================================
  Hits         40772    40772           
  Misses       24877    24877           
  Partials      2609     2609           
Flag Coverage Δ
unit 75.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@d-gubert d-gubert modified the milestones: 7.6.0, 7.5.0 Mar 24, 2025
@Gustrb Gustrb marked this pull request as ready for review March 24, 2025 20:30
@Gustrb Gustrb requested a review from a team as a code owner March 24, 2025 20:30
d-gubert
d-gubert previously approved these changes Mar 24, 2025
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Mar 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: dc1e541

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/apps-engine Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Gustrb Gustrb removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Mar 25, 2025
@d-gubert d-gubert changed the title fix: adding blocks from block builder to the changeset fix: adding blocks from block builder to the changes field Mar 25, 2025
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Mar 25, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 25, 2025
@kodiakhq kodiakhq bot merged commit 0d37ba7 into develop Mar 25, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/block-builder-set-block-not-working branch March 25, 2025 19:36
@d-gubert
Copy link
Member

/patch

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 27, 2025

Pull request #35637 added to Project: "undefined"

@sampaiodiego
Copy link
Member

/backport 7.4.2

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 7, 2025

Pull request #35719 added to Project: "Patch 7.4.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants